[
https://issues.apache.org/jira/browse/NIFI-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235993#comment-16235993
]
ASF GitHub Bot commented on NIFI-4559:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2246#discussion_r148575125
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
---
@@ -222,6 +231,16 @@ public ValidationResult validate(String subject,
String input, ValidationContext
.defaultValue(";")
.build();
+ static final PropertyDescriptor PENALIZE_NONZERO_STATUS = new
PropertyDescriptor.Builder()
--- End diff --
I wonder if this is necessary? The processor doesn't currently penalize
anything. I think it may make sense to always penalize when sending to the new
relationship and the user has the ability to just set Penalty Duration to "0
sec" if they don't want to penalize.
> ExecuteStreamCommand should have a failure relationship
> -------------------------------------------------------
>
> Key: NIFI-4559
> URL: https://issues.apache.org/jira/browse/NIFI-4559
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.4.0
> Reporter: Joseph Witt
> Assignee: Matt Burgess
> Priority: Major
>
> ExecuteStreamCommand only has a success relationship. The gist is it
> executes the command, captures the output stream, code, etc.. and stores the
> necessary content and attributes.
> However, for those wanting to see the status code as an indicator of failure
> they have to create a flow which checks, loops, etc.. This is more work than
> necessary since the processor can provide a better indicator. By adding a
> failure relationship we can route results and status codes for non-zero to
> this relationship. We'll have to consider backward compatibility friendly
> ideas but the gist is to make this common failure/retry pattern easier to
> configure and track.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
