[GitHub] nifi-minifi-cpp pull request #191: MINIFICPP-114 Consolidate JSON API use to...

[phrocker]

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151568839
  
    --- Diff: 
libminifi/src/core/reporting/SiteToSiteProvenanceReportingTask.cpp ---
    @@ -53,54 +56,92 @@ void SiteToSiteProvenanceReportingTask::initialize() {
       RemoteProcessorGroupPort::initialize();
     }
     
    +void setJsonStr(const std::string& key, const std::string& value, 
rapidjson::Value& parent, rapidjson::Document::AllocatorType& alloc) { // NOLINT
    --- End diff --
    
    why is this here too?


---