Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151580011
  
    --- Diff: extensions/rocksdb-repos/CMakeLists.txt ---
    @@ -23,7 +23,7 @@ cmake_minimum_required(VERSION 2.6)
     set(CMAKE_EXE_LINKER_FLAGS "-Wl,--export-all-symbols")
     set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--export-symbols")
     
    -include_directories(../../libminifi/include  ../../libminifi/include/core  
../../thirdparty/spdlog-20170710/include ../../thirdparty/concurrentqueue 
../../thirdparty/yaml-cpp-yaml-cpp-0.5.3/include 
../../thirdparty/civetweb-1.9.1/include ../../thirdparty/jsoncpp/include 
../../thirdparty/rocksdb/include  ../../thirdparty/) 
    --- End diff --
    
    @phrocker 1000x we need some standard includes/functions for the cmake 
files.


---

Reply via email to