[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269071#comment-16269071
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r153562525
--- Diff: .travis.yml ---
@@ -21,7 +21,7 @@ cache:
timeout: 300
env:
- CMAKE_BUILD_OPTIONS="-DENABLE_PCAP=TRUE"
+ CMAKE_BUILD_OPTIONS="-DENABLE_PCAP=TRUE -DEMABLE_USB_CAMERA=1
-DENABLE_GPS=1"
--- End diff --
Should this be ENABLE_USB_CAMERA ?
> Move extension tests and test headers, lint extensions
> ------------------------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
