[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274759#comment-16274759
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r154417158
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -87,26 +89,17 @@ HTTPClient::HTTPClient()
}
HTTPClient::~HTTPClient() {
- if (nullptr != headers_) {
- curl_slist_free_all(headers_);
- headers_ = nullptr;
- }
- if (http_session_ != nullptr) {
- curl_easy_cleanup(http_session_);
- http_session_ = nullptr;
- }
+ forceClose();
--- End diff --
Why did you remove the destruction of http_session_ ? That means we can't
reclaim resources and in some cases may result in a TCP socket in CLOSE_WAIT
> Move extension tests and test headers, lint extensions
> ------------------------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
