Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2304#discussion_r153818546
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/SimpleCsvFileLookupService.java
---
@@ -194,12 +194,12 @@ public void onEnabled(final ConfigurationContext
context) throws InitializationE
}
@Override
- public Optional<String> lookup(final Map<String, String> coordinates)
throws LookupFailureException {
+ public Optional<String> lookup(final Map<String, Object> coordinates)
throws LookupFailureException {
if (coordinates == null) {
return Optional.empty();
}
- final String key = coordinates.get(KEY);
+ final String key = coordinates.get(KEY) instanceof String ?
(String)coordinates.get(KEY) : coordinates.get(KEY).toString();
--- End diff --
Again, no need to check instanceof here - can just call toString()
---