Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2304#discussion_r153818651
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind/IPLookupService.java
---
@@ -237,8 +237,8 @@ public void closeReader() throws IOException {
}
}
- private Optional<Record> doLookup(final DatabaseReader databaseReader,
final Map<String, String> coordinates) throws LookupFailureException,
InvalidDatabaseException {
- final String ipAddress = coordinates.get(IP_KEY);
+ private Optional<Record> doLookup(final DatabaseReader databaseReader,
final Map<String, Object> coordinates) throws LookupFailureException,
InvalidDatabaseException {
+ final String ipAddress = coordinates.get(IP_KEY) instanceof String
? (String)coordinates.get(IP_KEY) : coordinates.get(IP_KEY).toString();
--- End diff --
Again, no need to check instanceof here - can just call toString()
---
