Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153901613
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -74,6 +74,7 @@ target_link_libraries(core-minifi ${UUID_LIBRARIES} 
${JSONCPP_LIB} yaml-cpp )
     find_package(ZLIB REQUIRED)
     include_directories(${ZLIB_INCLUDE_DIRS})
     
    +target_link_libraries(core-minifi minifi-expression-language-extensions)
    --- End diff --
    
    I'm surprised to see this here. This means the extension cannot be fully 
disabled, so then we rely on the noop? 


---

Reply via email to