Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153914128
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -74,6 +74,7 @@ target_link_libraries(core-minifi ${UUID_LIBRARIES} 
${JSONCPP_LIB} yaml-cpp )
     find_package(ZLIB REQUIRED)
     include_directories(${ZLIB_INCLUDE_DIRS})
     
    +target_link_libraries(core-minifi minifi-expression-language-extensions)
    --- End diff --
    
    Yeah we rely on the noop. Design intent is for noop to be optimized out at 
compile time, but would have to double-check that's the case. Maybe it should 
be explicitly inlined so we inline nothing. I'm open to suggestions.


---

Reply via email to