Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r154417158
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -87,26 +89,17 @@ HTTPClient::HTTPClient()
}
HTTPClient::~HTTPClient() {
- if (nullptr != headers_) {
- curl_slist_free_all(headers_);
- headers_ = nullptr;
- }
- if (http_session_ != nullptr) {
- curl_easy_cleanup(http_session_);
- http_session_ = nullptr;
- }
+ forceClose();
--- End diff --
Why did you remove the destruction of http_session_ ? That means we can't
reclaim resources and in some cases may result in a TCP socket in CLOSE_WAIT
---
