[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234472#comment-16234472
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168
MINIFICPP-280 Refactoring and various improvements
- move extension tests into their respective folders
- separate source and header files
- remove unnecessary or nonexisting include directories
- run linter on extension source files as part of linter target
- clean up extensions according to linter
- add ability to specify more than one include and source folder for linter
- build catch main() and spdlib as shared objects for all tests (faster
build!)
- cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
- borrow changes to tests from MINIFICPP-60 for parallel testing
- enable parallel testing in travis config
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NiFiLocal/nifi-minifi-cpp ExtensionLint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 37d64e50a378a812970a7c468bf3cd4051ba6cf7
Author: Caleb Johnson <[email protected]>
Date: 2017-11-01T16:52:55Z
MINIFICPP-280 Refactoring and various improvements
- move extension tests into their respective folders
- separate source and header files
- remove unnecessary or nonexisting include directories
- run linter on extension source files as part of linter target
- clean up extensions according to linter
- add ability to specify more than one include and source folder for linter
- build catch main() and spdlib as shared objects for all tests (faster
build!)
- cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
- borrow changes to tests from MINIFICPP-60 for parallel testing
- enable parallel testing in travis config
----
> Various refactoring and improvements
> ------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
> * build catch main() and spdlib as shared objects for all tests (faster
> build!)
> * cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
> * borrow port changes to tests from MINIFICPP-60 for parallel testing
> * enable parallel testing in travis config
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
