[
https://issues.apache.org/jira/browse/NIFI-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284559#comment-16284559
]
ASF GitHub Bot commented on NIFI-4684:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2333
NIFI-4684: Added SQL Parameter Attribute Prefix property to ConvertJSONToSQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2333
----
commit 6b40dfb0e9712571cdd5863f4fb990ae96987261
Author: Matthew Burgess <[email protected]>
Date: 2017-12-09T03:01:25Z
NIFI-4684: Added SQL Parameter Attribute Prefix property to ConvertJSONToSQL
----
> Add attribute prefix property to ConvertJSONToSQL
> -------------------------------------------------
>
> Key: NIFI-4684
> URL: https://issues.apache.org/jira/browse/NIFI-4684
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> Some users have tried to use ConvertJSONToSQL to generate SQL to put into
> Hive (possibly having to convert to HiveQL via ReplaceText). I'm not sure if
> NIFI-4071 still applies, but even so, when generating/accepting prepared
> statements, PutHiveQL expects attributes of the form
> "hiveql.args.N.type/value", where ConvertJSONToSQL generates attributes of
> the form "sql.args.N.type/value".
> To accommodate both use cases, we could add a property to ConvertJSONToSQL
> specifying the attribute prefix to use. It would default to "sql" to maintain
> existing behavior but allow the user to change to something like "hiveql" if
> they desire.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
