[ 
https://issues.apache.org/jira/browse/NIFI-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296533#comment-16296533
 ] 

ASF GitHub Bot commented on NIFI-4684:
--------------------------------------

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2333
  
    +1, code LGTM and confirmed expected behavior when using this processor for 
Hive operations. Merging to master.


> Add attribute prefix property to ConvertJSONToSQL
> -------------------------------------------------
>
>                 Key: NIFI-4684
>                 URL: https://issues.apache.org/jira/browse/NIFI-4684
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> Some users have tried to use ConvertJSONToSQL to generate SQL to put into 
> Hive (possibly having to convert to HiveQL via ReplaceText). I'm not sure if 
> NIFI-4071 still applies, but even so, when generating/accepting prepared 
> statements, PutHiveQL expects attributes of the form 
> "hiveql.args.N.type/value", where ConvertJSONToSQL generates attributes of 
> the form "sql.args.N.type/value". 
> To accommodate both use cases, we could add a property to ConvertJSONToSQL 
> specifying the attribute prefix to use. It would default to "sql" to maintain 
> existing behavior but allow the user to change to something like "hiveql" if 
> they desire.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to