[
https://issues.apache.org/jira/browse/NIFI-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295059#comment-16295059
]
ASF GitHub Bot commented on NIFI-4702:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2349
NIFI-4702: When we check the next line for matches in Grok Reader, st…
…ore the Map that is returned so that we don't have to re-evaluate the
regexes the next time that nextRecord() is called
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4702
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2349
----
commit 914833e9afdfdbe09ebfe210604a661311fa0a54
Author: Mark Payne <[email protected]>
Date: 2017-12-18T14:29:52Z
NIFI-4702: When we check the next line for matches in Grok Reader, store
the Map that is returned so that we don't have to re-evaluate the regexes the
next time that nextRecord() is called
----
> Grok Record Reader applies regex to each line twice in some situations
> ----------------------------------------------------------------------
>
> Key: NIFI-4702
> URL: https://issues.apache.org/jira/browse/NIFI-4702
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
>
> When using the Grok Record Reader, it reads the next line from the stream to
> check if it needs to be appended to the record, is the start of a stack
> trace, etc. When this is done, if the next line matches the configured
> pattern, it is stored as 'nextLine' but we don't store the Map that is
> obtained from calling captures(). This means that the next iteration of
> nextRecord() must re-evaluate the regexes against 'nextLine'. We should
> instead just keep the Map as a member variable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
