[
https://issues.apache.org/jira/browse/NIFI-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295072#comment-16295072
]
ASF GitHub Bot commented on NIFI-4702:
--------------------------------------
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2349
+1 LGTM, ran full build with unit tests and contrib-check, verified that
the behavior is maintained, and code indicates the performance improvement.
Thanks for the improvement! Merging to master
> Grok Record Reader applies regex to each line twice in some situations
> ----------------------------------------------------------------------
>
> Key: NIFI-4702
> URL: https://issues.apache.org/jira/browse/NIFI-4702
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
>
> When using the Grok Record Reader, it reads the next line from the stream to
> check if it needs to be appended to the record, is the start of a stack
> trace, etc. When this is done, if the next line matches the configured
> pattern, it is stored as 'nextLine' but we don't store the Map that is
> obtained from calling captures(). This means that the next iteration of
> nextRecord() must re-evaluate the regexes against 'nextLine'. We should
> instead just keep the Map as a member variable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
