[
https://issues.apache.org/jira/browse/NIFI-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296206#comment-16296206
]
ASF GitHub Bot commented on NIFI-4005:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2353
NIFI-4005: Add support for Azure Shared Access Signature (SAS) Tokens
This PR incorporated review comments based on #1886.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2353
----
commit 87d09faac5a11e5a34edcd1bbf2be20ce9ffe880
Author: Andrew Grande <apere...@gmail.com>
Date: 2017-05-31T20:45:26Z
NIFI-4005 Add support for Azure Shared Access Signature (SAS) Tokens.
Upgraded the client library from 5.0.0 to 5.2.0
commit 4f69235019901dac4bd0e38a541498c877ab273d
Author: Koji Kawamura <ijokaruma...@apache.org>
Date: 2017-12-19T02:35:00Z
NIFI-4005: Azure Blob Storage SAS support, incorporating review comments
- Renamed Azure to AzureStorageUtils.
- Fixed whitespacing in property description.
- Renamed SAS String to SAS Token.
----
> Add support for Azure Shared Access Signature (SAS) Tokens
> ----------------------------------------------------------
>
> Key: NIFI-4005
> URL: https://issues.apache.org/jira/browse/NIFI-4005
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Andrew Grande
> Assignee: Koji Kawamura
> Priority: Minor
>
> Azure's account name and key are treated as admin, 'root' access credentials.
> If one has those, every container under this account is fully accessible. An
> MSFT-recommended approach is to use SAS policies, which provide for a fine
> grained permission and object control, as well as defined expiration.
> I already have working code, filing this ticket to formally track and submit
> PR against next.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
