[ 
https://issues.apache.org/jira/browse/MINIFICPP-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316615#comment-16316615
 ] 

ASF GitHub Bot commented on MINIFICPP-357:
------------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/230

    MINIFICPP-357 Added support for config YAML v3.

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-357

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #230
    
----
commit badddf33f9b5ce07d0ffdd887b434bd9e0217334
Author: Andy I. Christianson <andy@...>
Date:   2018-01-04T18:00:27Z

    MINIFICPP-357 Added support for config YAML v3.

----


> Upgrade YAML parsing to support version 3 of the config schema and work with 
> later toolkits
> -------------------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-357
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-357
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Aldrin Piri
>            Assignee: Andrew Christianson
>         Attachments: 1.4-Template.xml, 1.5-Template.xml
>
>
> Currently minificpp makes use of what is effectively YAML, v1 and requires 
> the usage of the 0.0.1 toolkit to perform transformations.  We should get 
> these in sync across agent implementations and allow users to make use of one 
> toolkit for performing transformations.
> Scope involves mapping v3 config to what is currently supported. Not all 
> features in reference config files (e.g. dynamic properties) are yet 
> supported in MiNiFi. Support of those features is out of scope.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to