[ https://issues.apache.org/jira/browse/MINIFICPP-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317185#comment-16317185 ]
ASF GitHub Bot commented on MINIFICPP-357: ------------------------------------------ Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160269055 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -40,13 +40,18 @@ namespace core { #define CONFIG_YAML_CONNECTIONS_KEY "Connections" #define CONFIG_YAML_CONTROLLER_SERVICES_KEY "Controller Services" #define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY "Remote Processing Groups" +#define CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY_V3 "Remote Process Groups" #define CONFIG_YAML_PROVENANCE_REPORT_KEY "Provenance Reporting" class YamlConfiguration : public FlowConfiguration { public: - explicit YamlConfiguration(std::shared_ptr<core::Repository> repo, std::shared_ptr<core::Repository> flow_file_repo, std::shared_ptr<core::ContentRepository> content_repo, - std::shared_ptr<io::StreamFactory> stream_factory, std::shared_ptr<Configure> configuration, const std::string path = DEFAULT_FLOW_YAML_FILE_NAME) + explicit YamlConfiguration(std::shared_ptr<core::Repository> repo, --- End diff -- Will fix. > Upgrade YAML parsing to support version 3 of the config schema and work with > later toolkits > ------------------------------------------------------------------------------------------- > > Key: MINIFICPP-357 > URL: https://issues.apache.org/jira/browse/MINIFICPP-357 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Aldrin Piri > Assignee: Andrew Christianson > Fix For: 0.4.0 > > Attachments: 1.4-Template.xml, 1.5-Template.xml > > > Currently minificpp makes use of what is effectively YAML, v1 and requires > the usage of the 0.0.1 toolkit to perform transformations. We should get > these in sync across agent implementations and allow users to make use of one > toolkit for performing transformations. > Scope involves mapping v3 config to what is currently supported. Not all > features in reference config files (e.g. dynamic properties) are yet > supported in MiNiFi. Support of those features is out of scope. -- This message was sent by Atlassian JIRA (v6.4.14#64029)