Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160290778
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration {
*
* @param yamlNode a pointer to the YAML::Node that will be checked for
the
* presence of an idField
- * @param idField the string of the name of the idField to check for.
This
+ * @param field the string of the name of the idField to check for. This
* is optional and defaults to 'id'
* @return the parsed or generated UUID string
*/
- std::string getOrGenerateId(YAML::Node *yamlNode, const std::string
&idField = "id");
+ std::string getOrGenerateField(YAML::Node *yamlNode, const std::string
&field = "id");
--- End diff --
What is the end goal of this PR? It seems that you want to generalize the
function name to eventually be used elsewhere.
---
