Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160426137
  
    --- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
    @@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration {
        *
        * @param yamlNode a pointer to the YAML::Node that will be checked for 
the
        *                   presence of an idField
    -   * @param idField  the string of the name of the idField to check for. 
This
    +   * @param field  the string of the name of the idField to check for. This
        *                   is optional and defaults to 'id'
        * @return         the parsed or generated UUID string
        */
    -  std::string getOrGenerateId(YAML::Node *yamlNode, const std::string 
&idField = "id");
    +  std::string getOrGenerateField(YAML::Node *yamlNode, const std::string 
&field = "id");
    --- End diff --
    
    The checkRequiredField call was removed:
    
    ```diff
    -        checkRequiredField(&connectionNode, "name",
     -        CONFIG_YAML_CONNECTIONS_KEY);
    ```
    
    So the current behavior is that name can be left unspecified. In that case 
it will be generated.


---

Reply via email to