[
https://issues.apache.org/jira/browse/NIFIREG-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319969#comment-16319969
]
Danny Lane commented on NIFIREG-77:
-----------------------------------
Thanks [~bbende], that's helpful.
I had seen the NiFi code around the creating the FlowComparator and mapping to
the DTOs but like you said, i was still trying to work out what the response
from the new end-point should be.
At the moment it looks like most that I can see (all?) of the responses from
the {{nifi-registry-web-api}} and {{nifi-registry-client}} are types from
{{nifi-registry-data-model}}, {{FlowDifference}} isn't in the model module. Is
there any issue with this? and adding {{nifi-registry-flow-diff}} as a
dependency to both the api and client? This may be fine, I just wanted to
confirm I wasn't breaking the pattern.
What I was thinking about before I read your comment above was to put the
FlowComparator logic in {{org.apache.nifi.registry.service.RegistryService}}
and map to/return new types in the data-model module. so the client & api
wouldn't need new references to the diff module. This might not even be an
issue?
I'm happy enough to go either route, let me know what you prefer and I'll start
putting something together.
> Allow a user to see the changes created by the currently loaded version
> -----------------------------------------------------------------------
>
> Key: NIFIREG-77
> URL: https://issues.apache.org/jira/browse/NIFIREG-77
> Project: NiFi Registry
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Joseph Percivall
> Priority: Critical
> Attachments: Suggestion for diff UX.png
>
>
> As a user, I would like to see the changes that are included in a particular
> version. More specifically, if I'm on an old version and I upgrade to a
> version written by someone else, I have no way to know what changes occurred
> during that version upgrade.
> A simple solution would be to utilize the same logic which displays the
> current differences between local and stored in the registry and use that to
> show the differences between the current version N and version N-1. The user
> could then change between versions to see the changes that happened as part
> of that version.
> An even better solution (from a DFM perspective) would be to be able to see
> the changes within any version (not just the most recent). That way a DFM
> wouldn't have to stop the flow for an extended period of time to view the
> changes/differences in different versions but I think that'd be more work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
