[ 
https://issues.apache.org/jira/browse/NIFIREG-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320464#comment-16320464
 ] 

Bryan Bende commented on NIFIREG-77:
------------------------------------

[~DannyLane] that is a good point about introducing a new dependency, we 
definitely want to be very careful about what gets introduced to the client 
module so that people using it aren't forced to bring in all kinds of stuff.

In this case, since {{nifi-registry-flow-diff}} only has a single dependency 
which is {{nifi-registry-data-model}}, I would be ok with the client also 
depending on flow diff, and we know NiFi already depends on flow diff so it 
would be ok from that perspective.

I'm not opposed to your original idea though (adding new data model classes and 
keeping the flow diff stuff hidden away), I was just trying to think of how to 
make it easiest to integrate on the NiFi side.

In either case, I would do what you suggested about putting the core logic of 
the comparison in {{RegistryService}}, and from there its just a matter of 
deciding if that should return stuff from flow diff, or some new objects from 
data model.

> Allow a user to see the changes created by the currently loaded version
> -----------------------------------------------------------------------
>
>                 Key: NIFIREG-77
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-77
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Joseph Percivall
>            Priority: Critical
>         Attachments: Suggestion for diff UX.png
>
>
> As a user, I would like to see the changes that are included in a particular 
> version. More specifically, if I'm on an old version and I upgrade to a 
> version written by someone else, I have no way to know what changes occurred 
> during that version upgrade.
> A simple solution would be to utilize the same logic which displays the 
> current differences between local and stored in the registry and use that to 
> show the differences between the current version N and version N-1. The user 
> could then change between versions to see the changes that happened as part 
> of that version.
> An even better solution (from a DFM perspective) would be to be able to see 
> the changes within any version (not just the most recent). That way a DFM 
> wouldn't have to stop the flow for an extended period of time to view the 
> changes/differences in different versions but I think that'd be more work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to