Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2424
  
    Another approach, rather than "unwrapping" column names that are specified 
with dialect-specific characters in the properties, is to have them specified 
without the characters in the property, and the generated SQL would "wrap" them 
with the characters. This is the way I've seen it done before, by adding 
"getStartQuote" and "getEndQuote" methods to the DatabaseAdapter (possibly one 
set for table/DB names and one for column names in case they are specified 
differently in the dialect, I think at least one DB has different quotes for 
tables vs columns but I can't think of which one offhand). With the "wrap" 
approach, there are two downsides:
    
    1) Users will have to change their properties to remove the special 
characters. However if this bug is saying that the special-character approach 
already doesn't work, then perhaps this is a non-issue.
    2) We won't support column names that have commas in them. Again, we don't 
currently support this unless it happens to work with the special characters.
    
    The upside is that the property values would be more "natural", just a 
comma-separated list of column names (possibly with spaces or other values in 
them), and we don't have to rely on a regex to "unwrap" them, rather we would 
only "wrap" them internally when needed for the generated SQL.


---

Reply via email to