Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2424
@mattyb149 Thanks for your suggestion. I considered that path, too. But I
did it this way as it seems simpler to the objective to address the issue.
However, I think your comment is a good point. And I prefer having wrap method
in DatabaseAdapters instead of unwrap.
Let's discuss a bit more. I noticed that table and column names are spilled
into few places. I think we should define how we want those to be set.
- Processor properties:
- Columns to Return
- Maximum Value Columns
- Additional WHERE clause
- Custom SQL (to be added by #2162)
- Additional WHERE clause and Custom SQL might be challenging to wrap
problematic identifies by Processor automatically.
- Processor State: Stored with a key in `{tableName}!@!{columnName}`
format. Do we want to keep database specific characters here?
- Output FlowFile Attributes:
- max.{columnName} = {maxValue}
- tableName = {tableName]
- Do we want to keep database specific characters here?
Even if we change DatabaseAdapter method from unwrap to wrap, it's still
possible to use wrap character to unwrap. But we need to make a consensus on
how above listed variables are written.
---
