[ 
https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346677#comment-16346677
 ] 

ASF GitHub Bot commented on NIFIREG-120:
----------------------------------------

Github user Chaffelson commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/89#discussion_r165030284
  
    --- Diff: nifi-registry-docker/dockerhub/DockerImage.txt ---
    @@ -0,0 +1,16 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +apache/nifi-registry:0.1.0
    --- End diff --
    
    @kevdoran I don't know if there's a convention, but looking at the changes 
to the equivalent NiFi file I think they do not use snapshot, just the base tag 
name.
    This would also be more in line with how most Docker tags look


> Basic Docker Image
> ------------------
>
>                 Key: NIFIREG-120
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-120
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Daniel Chaffelson
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It would be convenient if NiFi Registry had an integrated Docker image ready 
> for uploading to Dockerhub, similar to the main NiFi Project, for ease of 
> integration testing.
> This could probably be ported, with some changes, from the same approach used 
> in the main NiFi project for continuity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to