ASF GitHub Bot commented on NIFIREG-120:

Github user kevdoran commented on a diff in the pull request:

    --- Diff: nifi-registry-docker/dockerhub/README.md ---
    @@ -0,0 +1,127 @@
    +  Licensed to the Apache Software Foundation (ASF) under one or more
    +  contributor license agreements.  See the NOTICE file distributed with
    +  this work for additional information regarding copyright ownership.
    +  The ASF licenses this file to You under the Apache License, Version 2.0
    +  (the "License"); you may not use this file except in compliance with
    +  the License.  You may obtain a copy of the License at
    +      http://www.apache.org/licenses/LICENSE-2.0
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +# Docker Image Quickstart
    +## Capabilities
    +This image currently supports running in standalone mode either unsecured 
or with user authentication provided through:
    +   * [Two-Way SSL with Client 
    +   * [Lightweight Directory Access Protocol 
    +## Building
    +The Docker image can be built using the following command:
    +    . 
    +This will attempt to build and tag an image matching the string in 
    +    dockerhub dchaffey$ cat DockerImage.txt
    +    > apache/nifi-registry:0.1.0
    +    docker images
    +    > REPOSITORY               TAG                 IMAGE ID            
CREATED             SIZE
    +    > apache/nifi-registry     0.1.0               751428cbf631        15 
minutes ago      342MB
    +**Note**: The default version of NiFi-Registry specified by the Dockerfile 
is typically that of one that is unreleased if working from source.
    +To build an image for a prior released version, one can override the 
`NIFI_REGISTRY_VERSION` build-arg with the following command:
    +    docker build --build-arg=NIFI_REGISRTY_VERSION={Desired NiFi-Registry 
Version} -t apache/nifi-registry:latest .
    +There is, however, no guarantee that older versions will work as 
properties have changed and evolved with subsequent releases.
    +The configuration scripts are suitable for at least 0.1.0+.
    +## Running a container
    +### Standalone Instance, Unsecured
    +The minimum to run a NiFi Registry instance is as follows:
    +    . 
    --- End diff --
    Same for this section. 

> Basic Docker Image
> ------------------
>                 Key: NIFIREG-120
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-120
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Daniel Chaffelson
>            Priority: Minor
>             Fix For: 0.2.0
> It would be convenient if NiFi Registry had an integrated Docker image ready 
> for uploading to Dockerhub, similar to the main NiFi Project, for ease of 
> integration testing.
> This could probably be ported, with some changes, from the same approach used 
> in the main NiFi project for continuity.

This message was sent by Atlassian JIRA

Reply via email to