ASF GitHub Bot commented on NIFIREG-120:

Github user kevdoran commented on a diff in the pull request:

    --- Diff: nifi-registry-docker/dockerhub/Dockerfile ---
    @@ -0,0 +1,56 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements. See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership. The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License. You may obtain a copy of the License at
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# KIND, either express or implied. See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +FROM openjdk:8-jdk-slim
    +LABEL maintainer="Apache NiFi <d...@nifi.apache.org>"
    +LABEL site="https://nifi.apache.org";
    +ARG UID=1000
    +ARG GID=1000
    --- End diff --
    This should be bumped to the next release version (0.2.0) as the default so 
that when master gets released as a stable 0.2.0, this matches that. Older 
versions can be specified as a build arg, as in the readme.

> Basic Docker Image
> ------------------
>                 Key: NIFIREG-120
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-120
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Daniel Chaffelson
>            Priority: Minor
>             Fix For: 0.2.0
> It would be convenient if NiFi Registry had an integrated Docker image ready 
> for uploading to Dockerhub, similar to the main NiFi Project, for ease of 
> integration testing.
> This could probably be ported, with some changes, from the same approach used 
> in the main NiFi project for continuity.

This message was sent by Atlassian JIRA

Reply via email to