Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2464#discussion_r167388849
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java
 ---
    @@ -549,11 +551,7 @@ public String toTransitUri(String tableName, String 
rowKey) {
                 logger.warn("Connection has not been established, could not 
create a transit URI. Returning null.");
                 return null;
             }
    -        try {
    -            final String masterAddress = 
connection.getAdmin().getClusterStatus().getMaster().getHostAndPort();
    -            return "hbase://" + masterAddress + "/" + tableName + (rowKey 
!= null && !rowKey.isEmpty() ? "/" + rowKey : "");
    -        } catch (IOException e) {
    -            throw new RuntimeException("Failed to get HBase Admin 
interface, due to " + e, e);
    -        }
    +        final String transitUriMasterAddress = 
StringUtils.isEmpty(masterAddress) ? "unknown" : masterAddress;
    --- End diff --
    
    We are sending back "unknown" if the master address is empty. Won't that be 
a problem, if it happens to be empty? I mean when 
`session.getProvenanceReporter().fetch(handlerFlowFile, transitUri);` gets 
executed on the HBase processors?


---

Reply via email to