Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2464#discussion_r167389731
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientService.java
---
@@ -549,11 +551,7 @@ public String toTransitUri(String tableName, String
rowKey) {
logger.warn("Connection has not been established, could not
create a transit URI. Returning null.");
return null;
}
- try {
- final String masterAddress =
connection.getAdmin().getClusterStatus().getMaster().getHostAndPort();
- return "hbase://" + masterAddress + "/" + tableName + (rowKey
!= null && !rowKey.isEmpty() ? "/" + rowKey : "");
- } catch (IOException e) {
- throw new RuntimeException("Failed to get HBase Admin
interface, due to " + e, e);
- }
+ final String transitUriMasterAddress =
StringUtils.isEmpty(masterAddress) ? "unknown" : masterAddress;
--- End diff --
@zenfenan Thanks for your comment. Yes, it would be a problem if this
actually happens. But it only happens when the ControllerService was not able
to get the master address when it was enabled. I think HBase processors will
not be able to access HBase, too.
It depends on the programs how critical this can be, for those use the
returned transit URI later. For example, NiFi and Atlas integration case,
ReportLineageToAtlas reporting task will not be able to determine the right
cluster name in Atlas.
Please let me know any situation that the ControllerServer can connect to a
HBase, but can not get its master address. I write the code that way just to be
more protective, but not sure if that actually happens.
---
