Github user pvillard31 commented on a diff in the pull request:
    --- Diff: 
    @@ -103,6 +103,17 @@
    +    static final PropertyDescriptor VISIBLITY_LABEL = new 
    +            .name("delete-visibility-label")
    +            .displayName("Visibility Label")
    +            .description("If visibility labels are enabled, a row cannot 
be deleted without supplying its visibility label(s) in the delete " +
    +                    "request. Note: this visibility label will be applied 
to all cells within the row that is specified. If some cells have " +
    +                    "different visibility labels, they will not be 
deleted. When that happens, the failure to delete will be considered a success 
" +
    +                    "because HBase does not report it as a failure.")
    +            .required(false)
    --- End diff --
    Since this is not required and always valid, a user could force the 
property to be set with an empty string. Is that OK? It means visibility would 
be equal to "". Does that make sense in some cases? Wouldn't be better to add a 
non-empty string validator?


Reply via email to