ASF GitHub Bot commented on NIFI-4743:

Github user pvillard31 commented on a diff in the pull request:

    --- Diff: 
    @@ -284,6 +306,17 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
    +        final NullSuppression suppression;
    --- End diff --
    Not sure we need this variable. We can directly use 
````this.nullSuppression````in the below block, no?

> Suppress Nulls for PutElasticsearchHttpRecord
> ---------------------------------------------
>                 Key: NIFI-4743
>                 URL: https://issues.apache.org/jira/browse/NIFI-4743
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Robert Bruno
>            Assignee: Mike Thomsen
>            Priority: Minor
>         Attachments: NullSuppression.java, PutElasticsearchHttpRecord.java
> Would be useful for PutElasticsearchHttpRecord to allow you to suppress NULL 
> values in the JSON that is inserted into ES much like the JsonRecordSetWriter 
> allows you to do.  Perhaps PutElasticsearchHttpRecord could some how make use 
> of JsonRecordSetWriter so it would inherit this functionality.

This message was sent by Atlassian JIRA

Reply via email to