[ 
https://issues.apache.org/jira/browse/NIFI-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397776#comment-16397776
 ] 

ASF GitHub Bot commented on NIFI-4743:
--------------------------------------

Github user robertrbruno commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2501#discussion_r174305856
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ---
    @@ -284,6 +306,17 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
                     return;
             }
     
    +        final NullSuppression suppression;
    --- End diff --
    
    Agreed that this.nullSuppression could be directly set without the need of 
this variable.


> Suppress Nulls for PutElasticsearchHttpRecord
> ---------------------------------------------
>
>                 Key: NIFI-4743
>                 URL: https://issues.apache.org/jira/browse/NIFI-4743
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Robert Bruno
>            Assignee: Mike Thomsen
>            Priority: Minor
>         Attachments: NullSuppression.java, PutElasticsearchHttpRecord.java
>
>
> Would be useful for PutElasticsearchHttpRecord to allow you to suppress NULL 
> values in the JSON that is inserted into ES much like the JsonRecordSetWriter 
> allows you to do.  Perhaps PutElasticsearchHttpRecord could some how make use 
> of JsonRecordSetWriter so it would inherit this functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to