Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2429#discussion_r175183514
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogarithmicallyPenalizeFlowFileProcessor.java
 ---
    @@ -0,0 +1,122 @@
    +package org.apache.nifi.processors.standard;
    +
    +import java.util.Arrays;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.util.StandardValidators;
    +
    +public class LogarithmicallyPenalizeFlowFileProcessor extends 
AbstractProcessor {
    --- End diff --
    
    I would suggest a simpler name: PenalizeFlowFile. Generally we avoid use of 
the word 'Processor' in our naming conventions and the fact that it is 
logarithmic is probably not important in describing the main concept of the 
processor but is a bit of a mouthful to say :)


---

Reply via email to