Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2429#discussion_r175184911
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogarithmicallyPenalizeFlowFileProcessor.java
 ---
    @@ -0,0 +1,122 @@
    +package org.apache.nifi.processors.standard;
    +
    +import java.util.Arrays;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Set;
    +
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.util.StandardValidators;
    +
    +public class LogarithmicallyPenalizeFlowFileProcessor extends 
AbstractProcessor {
    +
    +    private static final PropertyDescriptor INITIAL_RECONNECT_TIMEOUT = 
new PropertyDescriptor.Builder()
    +            .name("initialReconnectTimeout")
    +            .displayName("InitialReconnectTimeoutMs")
    +            .description("First delay length after first FlowFile arrival 
in millis")
    +            .defaultValue("50")
    +            .required(true)
    +            .expressionLanguageSupported(false)
    +            .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
    +            .build();
    +
    +    private static final PropertyDescriptor MAXIMAL_RECONNECT_TIMEOUT = 
new PropertyDescriptor.Builder()
    +            .name("maximalReconnectTimeout")
    +            .displayName("MaximalReconnectTimeoutMs")
    +            .description("Maximal delay length after first FlowFile 
arrival in millis")
    +            .defaultValue(""+10*60*1000)//10 minutes
    +            .required(true)
    +            .expressionLanguageSupported(false)
    +            .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
    +            .build();
    +
    +    private static final PropertyDescriptor MAXIMAL_NUMBER_OF_RETRIES = 
new PropertyDescriptor.Builder()
    +            .name("maximalNumberOfRetries")
    +            .displayName("maximalNumberOfRetries")
    --- End diff --
    
    Should use a display name like "Maximum Number of Retries" (generally we 
tend to use the term 'Maximum' in our conventions over Maximal, though either 
is considered correct grammatically).


---

Reply via email to