[ 
https://issues.apache.org/jira/browse/MINIFICPP-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408545#comment-16408545
 ] 

ASF GitHub Bot commented on MINIFICPP-440:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/289#discussion_r176229379
  
    --- Diff: CMakeLists.txt ---
    @@ -25,8 +25,10 @@ set(PROJECT_VERSION_MINOR 4)
     set(PROJECT_VERSION_PATCH 0)
     option(SKIP_TESTS "Skips building all tests." OFF)
     option(PORTABLE "Instructs the compiler to remove architecture specific 
optimizations" ON)
    +option(USE_SYSTEM_OPENSSL "Instructs the build system to search for and 
use an SSL library available in the host system" OFF)
    --- End diff --
    
    I'm not in favor of changing the system dependency in a minor release. I 
would be in favor of moving to USE_SYSTEM_OPENSSL as the default until the next 
major release. 


> Build & statically link libressl when not available in system
> -------------------------------------------------------------
>
>                 Key: MINIFICPP-440
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-440
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> In order to target systems where no SSL library is available, we should 
> support buildingĀ  & statically linking LibreSSL. This will help make MiNiFi - 
> C++ more portable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to