[
https://issues.apache.org/jira/browse/MINIFICPP-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408552#comment-16408552
]
ASF GitHub Bot commented on MINIFICPP-440:
------------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/289#discussion_r176231138
--- Diff: CMakeLists.txt ---
@@ -25,8 +25,10 @@ set(PROJECT_VERSION_MINOR 4)
set(PROJECT_VERSION_PATCH 0)
option(SKIP_TESTS "Skips building all tests." OFF)
option(PORTABLE "Instructs the compiler to remove architecture specific
optimizations" ON)
+option(USE_SYSTEM_OPENSSL "Instructs the build system to search for and
use an SSL library available in the host system" OFF)
--- End diff --
OK I'll invert that default. The thinking is that building/static-linking
makes the binary more portable and that's probably the config we want for the
release binary. But I agree it's a fairly significant change for a minor
release.
> Build & statically link libressl when not available in system
> -------------------------------------------------------------
>
> Key: MINIFICPP-440
> URL: https://issues.apache.org/jira/browse/MINIFICPP-440
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> In order to target systems where no SSL library is available, we should
> support building & statically linking LibreSSL. This will help make MiNiFi -
> C++ more portable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
