Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2597#discussion_r178111708
  
    --- Diff: 
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java
 ---
    @@ -202,9 +204,9 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
             final CSVFormat csvFormat = CSVUtils.createCSVFormat(context);
     
             //Switch to 0 based index
    -        final int firstRow = context.getProperty(ROWS_TO_SKIP).asInteger() 
- 1;
    +        final int firstRow = 
Integer.parseInt(context.getProperty(ROWS_TO_SKIP).evaluateAttributeExpressions().getValue())
 - 1;
    --- End diff --
    
    I'd do:
    ````java
    final int firstRow = 
context.getProperty(ROWS_TO_SKIP).evaluateAttributeExpressions(flowFile).asInteger()
 - 1;
    ````
    Note that I use the EL evaluation against the flow file, otherwise you 
won't look at the incoming FF attributes.


---

Reply via email to