[
https://issues.apache.org/jira/browse/NIFI-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419308#comment-16419308
]
ASF GitHub Bot commented on NIFI-5017:
--------------------------------------
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2597#discussion_r178111708
--- Diff:
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java
---
@@ -202,9 +204,9 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CSVFormat csvFormat = CSVUtils.createCSVFormat(context);
//Switch to 0 based index
- final int firstRow = context.getProperty(ROWS_TO_SKIP).asInteger()
- 1;
+ final int firstRow =
Integer.parseInt(context.getProperty(ROWS_TO_SKIP).evaluateAttributeExpressions().getValue())
- 1;
--- End diff --
I'd do:
````java
final int firstRow =
context.getProperty(ROWS_TO_SKIP).evaluateAttributeExpressions(flowFile).asInteger()
- 1;
````
Note that I use the EL evaluation against the flow file, otherwise you
won't look at the incoming FF attributes.
> ConvertExcelToCSVProcessor should Support Expression Language for Number of
> Rows to Skip and Columns To Skip
> -------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5017
> URL: https://issues.apache.org/jira/browse/NIFI-5017
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.5.0
> Reporter: Arun A K
> Priority: Minor
>
> The ConvertExcelToCSVProcessor should support expression language for fields
> "Number of Rows to Skip" and "Columns To Skip". These two could be a
> precomputed attribute or looked up value and need to be configurable via EL.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
