[
https://issues.apache.org/jira/browse/NIFI-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419337#comment-16419337
]
ASF GitHub Bot commented on NIFI-5017:
--------------------------------------
Github user ak-arun commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2597#discussion_r178116509
--- Diff:
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/test/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessorTest.java
---
@@ -187,6 +213,34 @@ public void testSkipColumns() throws Exception {
"9.8765E+08,\n");
}
+ @Test
+ public void testSkipColumnsWithEL() throws Exception {
+ testRunner.enqueue(new
File("src/test/resources/dataformatting.xlsx").toPath());
--- End diff --
@pvillard31 do you want me to re-write the tests into a single method?
initially there were separate methods for testing the skipRows and skipColumns,
I just maintained the same format.
> ConvertExcelToCSVProcessor should Support Expression Language for Number of
> Rows to Skip and Columns To Skip
> -------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5017
> URL: https://issues.apache.org/jira/browse/NIFI-5017
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.5.0
> Reporter: Arun A K
> Priority: Minor
>
> The ConvertExcelToCSVProcessor should support expression language for fields
> "Number of Rows to Skip" and "Columns To Skip". These two could be a
> precomputed attribute or looked up value and need to be configurable via EL.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
