[ 
https://issues.apache.org/jira/browse/NIFI-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423067#comment-16423067
 ] 

ASF GitHub Bot commented on NIFI-3576:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2601#discussion_r178636130
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java
 ---
    @@ -255,6 +325,8 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
                     .evaluateAttributeExpressions(flowFile).getValue() : null;
             final boolean targetIsContent = 
context.getProperty(TARGET).getValue()
                     .equals(TARGET_FLOW_FILE_CONTENT);
    +        final boolean includeQueryInAttrs = 
context.getProperty(INCLUDE_QUERY_IN_ATTRS).isSet() ?
    --- End diff --
    
    CheckStyle violation here, the ? should be on the next line. You can run 
your Maven build for the nifi-elasticsearch-bundle with the contrib-check 
profile activated (`-Pcontrib-check`) and it will run a style check for you.


> QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-3576
>                 URL: https://issues.apache.org/jira/browse/NIFI-3576
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Otto Fowler
>            Priority: Minor
>
> In the event of a successful call, QueryElasticsearchHttp always drops the 
> incoming flowfile and then emits pages of results to the success 
> relationship. If the search returns no results then no pages of results are 
> emitted to the success relationship. 
> The processor should offer other options for handling when there are no 
> results returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to