[ 
https://issues.apache.org/jira/browse/NIFI-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423995#comment-16423995
 ] 

ASF GitHub Bot commented on NIFI-3576:
--------------------------------------

Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2601#discussion_r178817080
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java
 ---
    @@ -175,16 +197,30 @@
                 .allowableValues(TARGET_FLOW_FILE_CONTENT, 
TARGET_FLOW_FILE_ATTRIBUTES)
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR).build();
     
    -    private static final Set<Relationship> relationships;
    +    public static final PropertyDescriptor ROUTING_QUERY_INFO_STRATEGY = 
new PropertyDescriptor.Builder()
    +            .name("routing-query-info-strategy")
    +            .displayName("Routing Strategy for Query Info")
    +            .description("Specifies when to generate and route Query Info 
after a successful query")
    +            .expressionLanguageSupported(false)
    +            .allowableValues(ALWAYS, NEVER, NO_HITS)
    +            .defaultValue(NEVER.getValue())
    +            .required(false)
    +            .build();
    +
    +    public static final PropertyDescriptor INCLUDE_QUERY_IN_ATTRS = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Should we really need to have a property for this? Writing the 
`es.query.url` as an attribute by default sounds safe to me. Thoughts?


> QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-3576
>                 URL: https://issues.apache.org/jira/browse/NIFI-3576
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Otto Fowler
>            Priority: Minor
>
> In the event of a successful call, QueryElasticsearchHttp always drops the 
> incoming flowfile and then emits pages of results to the success 
> relationship. If the search returns no results then no pages of results are 
> emitted to the success relationship. 
> The processor should offer other options for handling when there are no 
> results returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to