Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2607#discussion_r179768108
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
    @@ -3846,6 +3851,73 @@ public QueueSize getTotalFlowFileCount(final 
ProcessGroup group) {
             return new QueueSize(count, contentSize);
         }
     
    +    public class GroupStatusCounts {
    --- End diff --
    
    This is nit-picky but given that this class can be declared as static, 
since it doesn't reference FlowController private variables/methods, and given 
that FlowController is already nearly 4,000 lines of code, I'd recommend 
pulling this class out into its own .java file instead of making it an inner 
class of FlowController.


---

Reply via email to