Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2617
  
    @MikeThomsen - just fyi, while merging a PR it's highly recommended to 
amend the commit message to include the magic words that will automatically 
close the github PR. The commands I usually execute when merging a PR are:
    
    ````
    git checkout master
    git pull origin master
    git fetch github
    git checkout github/pr/<PR ID>
    git checkout -b pr<PR ID>
    --- here you can do additional reviewing, maven builds, test with a running 
instance, etc ---
    git commit --amend -s
    --- you update the commit message to include "This closes #<PR ID>."
    git log
    --- the above command is to retrieve the commit ID ---
    git checkout master
    git cherry-pick <commit ID>
    git push origin master
    ````
    
    This is an example - there are probably other ways to do it.


---

Reply via email to