ASF GitHub Bot commented on NIFI-543:

Github user mcgilman commented on a diff in the pull request:

    --- Diff: 
    @@ -741,8 +742,8 @@
    -                    // show the execution node option if we're cluster or 
we're currently configured to run on the primary node only
    -                    if (nfClusterSummary.isClustered() || executionNode 
=== 'PRIMARY') {
    +                    // show the execution node option if we're clustered 
and execution node is not restricted to run only in primary node
    +                    if (nfClusterSummary.isClustered() && 
executionNodeRestricted !== true) {
    --- End diff --
    I believe the `executionNode === 'PRIMARY'` was in place to ensure the 
currently configured value is shown. If the current value is set to PRIMARY, 
but this instance is no longer clustered we need to render that fact. Once the 
user reconfigures this value, they will no longer be able to select this option 
(since the node isn't clustered and executionNode would be ALL). Hope this 
makes sense.

> Provide extensions a way to indicate that they can run only on primary node, 
> if clustered
> -----------------------------------------------------------------------------------------
>                 Key: NIFI-543
>                 URL: https://issues.apache.org/jira/browse/NIFI-543
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core Framework, Documentation & Website, Extensions
>            Reporter: Mark Payne
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
> There are Processors that are known to be problematic if run from multiple 
> nodes simultaneously. These processors should be able to use a 
> @PrimaryNodeOnly annotation (or something similar) to indicate that they can 
> be scheduled to run only on primary node if run in a cluster.

This message was sent by Atlassian JIRA

Reply via email to