[ 
https://issues.apache.org/jira/browse/NIFI-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443286#comment-16443286
 ] 

ASF GitHub Bot commented on NIFI-3576:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2601#discussion_r182589001
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestQueryElasticsearchHttpNoHits.java
 ---
    @@ -142,7 +142,7 @@ public void 
testQueryElasticsearchOnTrigger_Hits_NoHits() throws IOException {
                     runner.assertValid();
     
                     runner.setIncomingConnection(false);
    -                runAndVerify(3,1,0,true);
    +                runAndVerify(3,0,0,true);
    --- End diff --
    
    Should we run this with both 1 and 0 for coverage? I haven't looked into 
the parameter, just shooting from the hip :)


> QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-3576
>                 URL: https://issues.apache.org/jira/browse/NIFI-3576
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Otto Fowler
>            Priority: Minor
>
> In the event of a successful call, QueryElasticsearchHttp always drops the 
> incoming flowfile and then emits pages of results to the success 
> relationship. If the search returns no results then no pages of results are 
> emitted to the success relationship. 
> The processor should offer other options for handling when there are no 
> results returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to