[ 
https://issues.apache.org/jira/browse/NIFI-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448400#comment-16448400
 ] 

ASF GitHub Bot commented on NIFI-3576:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2601#discussion_r183458816
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java
 ---
    @@ -267,30 +267,28 @@ public void setup(ProcessContext context) {
     
         @Override
         public void onPropertyModified(final PropertyDescriptor descriptor, 
final String oldValue, final String newValue) {
    +        final Set<Relationship> routeQueryInfoRels = new HashSet<>();
    +        routeQueryInfoRels.add(REL_SUCCESS);
    +        routeQueryInfoRels.add(REL_FAILURE);
    +        routeQueryInfoRels.add(REL_RETRY);
    +
    +        final Set<Relationship> successRels = new HashSet<>();
    --- End diff --
    
    I don't think even needs to exist at this point because 
`routequeryInfoRels` effectively does all three use cases and only gets the 4th 
relationship based on the routing strategy. Might want to refactor that and 
change the name to be more appropriate to the overlap.


> QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-3576
>                 URL: https://issues.apache.org/jira/browse/NIFI-3576
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Otto Fowler
>            Priority: Minor
>
> In the event of a successful call, QueryElasticsearchHttp always drops the 
> incoming flowfile and then emits pages of results to the success 
> relationship. If the search returns no results then no pages of results are 
> emitted to the success relationship. 
> The processor should offer other options for handling when there are no 
> results returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to