Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2648#discussion_r182931405
--- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/pom.xml ---
@@ -167,10 +167,12 @@
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
+ <consoleOutput>true</consoleOutput>
<excludes combine.children="append">
<exclude>src/test/resources/scrypt.py</exclude>
-
<exclude>src/test/resources/secure_hash.key</exclude>
-
<exclude>src/test/resources/secure_hash_128.key</exclude>
+ <!-- use wildcard for below files as tests
generate additional files during the build -->
+ <exclude>**/secure_hash.key</exclude>
+ <exclude>**/secure_hash_128.key</exclude>
--- End diff --
`nifi-toolkit/nifi-toolkit-encrypt-config/secure_hash.key` is created when
I run mvn test on a Linux machine as follows:
```
mvn --projects nifi-toolkit/nifi-toolkit-encrypt-config -Pcontrib-check
-Dtest=org.apache.nifi.toolkit.encryptconfig.EncryptConfigMainTest#testShouldPerformFullOperationForNiFiPropertiesAndLoginIdentityProvidersAndAuthorizers
test
```
Excluding these files with wild card would address the RAT check failure,
but the created file is under directory which is version controlled with Git.
It's possible that someone may add the created file mistakenly into Git.
```
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
nifi-toolkit/nifi-toolkit-encrypt-config/secure_hash.key
nothing added to commit but untracked files present (use "git add" to track)
```
I filed [NIFI-5100](https://issues.apache.org/jira/browse/NIFI-5100) and am
looking for a way to avoid creating such file, or remove it after test.
---
