Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2648#discussion_r182934721
--- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/pom.xml ---
@@ -167,10 +167,12 @@
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
+ <consoleOutput>true</consoleOutput>
<excludes combine.children="append">
<exclude>src/test/resources/scrypt.py</exclude>
-
<exclude>src/test/resources/secure_hash.key</exclude>
-
<exclude>src/test/resources/secure_hash_128.key</exclude>
+ <!-- use wildcard for below files as tests
generate additional files during the build -->
+ <exclude>**/secure_hash.key</exclude>
+ <exclude>**/secure_hash_128.key</exclude>
--- End diff --
Thanks for taking a look! I don't know enough about the tool to make a
change to this behavior as it might have good reason it needs to work that way.
For now I will update the PR to disable the tests, and we can take our time to
discuss the best approach that looks at the tests and tool holistically.
---
