Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2518#discussion_r184279789
  
    --- Diff: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
 ---
    @@ -142,6 +161,16 @@
                 .allowableValues(NULL_FIELD_EMPTY, NULL_FIELD_SKIP)
                 .build();
     
    +    protected static final PropertyDescriptor VISIBILITY_RECORD_PATH = new 
PropertyDescriptor.Builder()
    +            .name("put-hb-rec-visibility-record-path")
    +            .displayName("Visibility String Record Path Root")
    +            .description("A record path that points to part of the record 
which contains a path to a mapping of visibility strings to record paths")
    +            .required(false)
    +            .addValidator(Validator.VALID)
    +            .build();
    --- End diff --
    
    I thought the record path is for pointing a record field containing a 
single visibility expression String value at the first time. But this expect 
the record path target to be a Map, which contains keys for specifying column 
qualifier to apply the visibility and value is the visibility expression.
    
    I propose to describe that at lease. Moreover, it would be helpful if we 
provide an Additional details page with some input record or json, sample 
configurations and result in HBase cells. This feature can be useful but fairy 
complex to use at the first time.


---

Reply via email to