Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2518#discussion_r184276347
  
    --- Diff: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java
 ---
    @@ -82,6 +79,8 @@ protected PutFlowFile createPut(final ProcessSession 
session, final ProcessConte
             final String columnQualifier = 
context.getProperty(COLUMN_QUALIFIER).evaluateAttributeExpressions(flowFile).getValue();
             final String timestampValue = 
context.getProperty(TIMESTAMP).evaluateAttributeExpressions(flowFile).getValue();
     
    +        final String visibilityStringToUse = 
pickVisibilityString(columnFamily, columnQualifier, flowFile, context);
    --- End diff --
    
    Since PutHBaseCell is mutating only one cell, it is more intuitive to 
provide a configuration property directly specifying a visibility label 
expression, IN ADDITION to the default ones using dynamic properties. Thoughts?


---

Reply via email to